Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how social login works in an Electron app #22

Open
brandonfancher opened this issue Mar 17, 2022 · 2 comments
Open

Investigate how social login works in an Electron app #22

brandonfancher opened this issue Mar 17, 2022 · 2 comments

Comments

@brandonfancher
Copy link
Contributor

We're considering "Sign in with Github" specifically, first.

What are our options? Redirect to auth in external browser and redirect with custom URL scheme? Display auth login in a browser window within the Electron app?

@valzav
Copy link
Contributor

valzav commented Mar 17, 2022

Open an external browser would be a better option - it wouldn't require a user to login to Github in the Electron app. This probably will require registering a custom protocol handle so it will open up the Electron window after oath redirect from Github

@brandonfancher
Copy link
Contributor Author

Yes, I agree. I think that's going to be the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants