Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom platforms. #66

Closed
Lucasthoelke opened this issue Sep 11, 2019 · 9 comments
Closed

Create custom platforms. #66

Lucasthoelke opened this issue Sep 11, 2019 · 9 comments

Comments

@Lucasthoelke
Copy link

Would it be possible that we can create custom platforms?

@apawlowskij
Copy link
Contributor

If you mean adding new supported platforms (defined in galaxy.api.const), then I do not see this possible in a foreseeable future unfortunately.

@Lucasthoelke
Copy link
Author

If you mean adding new supported platforms (defined in galaxy.api.const), then I do not see this possible in a foreseeable future unfortunately.

Ah ok, could you then add some 'custom1-10' ID's then? Because the 'generic' and 'test' ID's don't seem to do anything right now.

@apawlowskij
Copy link
Contributor

Definitions for new platforms (e.g. Test) were added only in python API, yet Galaxy Client update was needed for them to be supported. You could try now.
AFAIK generic should not be used at all.

@ivellios
Copy link

ivellios commented Sep 14, 2019

The generic platforms type is no longer used/visible/available at all. Then which one should be used for the plugin which is supposed to automatically add games from my own list (like list of games I have on DVDs)?

Having Custom1-Custom10 might be one of the solutions.

@ivellios
Copy link

Also test type crashes all the time upon Connect. Where will I find debug for that?

Should I provide Authentication in case of test type?

@apawlowskij
Copy link
Contributor

All logs (you will be interested in the GalaxyClient.log and plugin-test-...log) are located in c:\ProgramData\GOG.com\Galaxy\logs\ on Windows.
Plugin needs at least authenticate and one of the feature methods (e.g. get_local_games), even if they return no real data. Otherwise GLX is stuck on launching it. It's a know issue, but has a low priority, as this should never happen in a real world with a working plugin.
We'll consider adding Custom platforms in near future. As a workaround you can manually Mark as owned these games in the GLX Client, or use any spare platforms.

@Countryen
Copy link

+1 for custom IDs / a "generic" ID

BTW: As of April, 8, I've got "test" running but not "generic" (as said).
Also "unknown" doesn't work, too.
(Maybe remove them from the "List of IDs if they are not meant to be used"?)

Thanks for the info about the logs, please add that to the documentation / readme.

@mbanczerowski
Copy link
Contributor

I've added discussed proposals in 9745dcd
Custom platform(s) need to wait for now.

@mbanczerowski
Copy link
Contributor

Custom platforms issue waits for resolution in the task mentioned above. Thanks for discussion and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants