Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload image does not handle suburl #1603

Closed
carli2 opened this issue Sep 8, 2015 · 15 comments
Closed

Upload image does not handle suburl #1603

carli2 opened this issue Sep 8, 2015 · 15 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Milestone
0.7.0

Comments

@carli2
Copy link

carli2 commented Sep 8, 2015

It would be nice to have some log message like "please chmod 666 on folder xyz" or similar. Uploads don't work. I just see a broken image.

Uploading creates a database entry in table attachment. /home/gogs shows no additional files.
@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

Thanks your feedback!

But I'm not quite understood the problem you're describing:

It would be nice to have some log message like "please chmod 666 on folder xyz" or similar.

How do you determine this is a chmod issue?

I just see a broken image.

What do you mean by broken image?

/home/gogs shows no additional files.

Attachments are saved in path/to/gogs/data/attchements

@unknwon unknwon added the status: needs feedback Tell me more about it label Sep 8, 2015
@unknwon unknwon added this to the 0.7.0 milestone Sep 8, 2015
@carli2
Copy link
Author

carli2 commented Sep 8, 2015

The issue is that I don't know why it dosen't work and I don't get any clue why.

Do I have to create the folder data/attachments?

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

The issue is that I don't know why it dosen't work and I don't get any clue why.

Can you take a screenshot for comment page after uploaded a image that is failed?

Do I have to create the folder data/attachments?

No

@carli2
Copy link
Author

carli2 commented Sep 8, 2015

bildschirmfoto von 2015-09-08 12-43-55

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

Please take another screenshot for you uploaded image but not yet click on "comment" button.

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

And what does web console says about this image request?

And log from Gogs?

@carli2
Copy link
Author

carli2 commented Sep 8, 2015

bildschirmfoto von 2015-09-08 14-05-36

No log messages in gogs.log
web-1.log:
[Macaron] Started POST /issues/attachments for 188.101.157.237
2015/09/08 14:27:01 [T] New attachment uploaded: 93824b6b-0c72-436f-a3db-b06bc8af7382
[Macaron] Completed /issues/attachments 200 OK in 4.293742475s

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

Thanks!

Can you open the web console and see what is the response code for the broken image after you posted comment?

@carli2
Copy link
Author

carli2 commented Sep 8, 2015

GET
http://launix.de/attachments/0e8e0660-3edd-4505-b113-2182d7642b5e [HTTP/1.1 404 Not Found 57ms]
GET
http://launix.de/attachments/93824b6b-0c72-436f-a3db-b06bc8af7382 [HTTP/1.1 404 Not Found 78ms]
GET
http://launix.de/attachments/b924b7da-ebf3-4bca-b45b-d61c2b69b650 [HTTP/1.1 404 Not Found 77ms]

@carli2
Copy link
Author

carli2 commented Sep 8, 2015

Oh, seems I found the reason: our gogs installation is reachable under http://launix.de/gogs
You forgot to add the sub-path to the download url.

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

Oh, seems I found the reason: our gogs installation is reachable under http://launix.de/gogs
You forgot to add the sub-path to the download url.

Right!

unknwon added a commit that referenced this issue Sep 8, 2015
@unknwon
#1603 suburl for comment attachments
6f6f38e
@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

I've pushed fix to master, please help test again!

@unknwon unknwon added the 💊 bug Something isn't working label Sep 8, 2015
@carli2
Copy link
Author

carli2 commented Sep 8, 2015

Maybe it makes sense for you to test from an installation with a non-empty suburl to prevent any of these flaws.

@unknwon
Copy link
Member

unknwon commented Sep 8, 2015

@carli2 yeah, I'll try to setup a local installation with suburl while developing.

@unknwon unknwon changed the title Upload of image fails without any notice Upload image does not handle suburl Sep 13, 2015
@unknwon
Copy link
Member

unknwon commented Sep 13, 2015

Closed as fixed.

@unknwon unknwon closed this as completed Sep 13, 2015
@unknwon unknwon modified the milestones: 0.8.0, 0.7.0 Oct 24, 2015
barracks510 added a commit to barracks510/gogs that referenced this issue Jul 16, 2016
@barracks510
api: delete repository webhooks
4b3f152 
Allows the deletion of a webhook from a repository at the
/:user/:repo/hooks/:id endpoint.

Solves drone/drone issue gogs#1603.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
@barracks510 barracks510 mentioned this issue Jul 16, 2016
Merged
barracks510 added a commit to barracks510/gogs that referenced this issue Jul 16, 2016
@barracks510
api: delete repository webhooks
d78aac5 
Allows the deletion of a webhook from a repository at the
/:user/:repo/hooks/:id endpoint.

Solves drone/drone issue gogs#1603.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
unknwon pushed a commit that referenced this issue Jul 17, 2016
@barracks510 @unknwon
api: delete repository webhooks (#3275)
5ff2dfb 
Allows the deletion of a webhook from a repository at the
/:user/:repo/hooks/:id endpoint.

Solves drone/drone issue #1603.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@carli2 @unknwon