Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Pull Request" option #1829

Closed
ChangePlaces opened this issue Oct 23, 2015 · 10 comments
Closed

Remove "Pull Request" option #1829

ChangePlaces opened this issue Oct 23, 2015 · 10 comments
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Milestone

Comments

@ChangePlaces
Copy link

As a developer, I use Gogs for my own personal projects because it's small, light and fast. I don't have any pull requests for projects so it would be nice, if in the options somewhere, there's an option to remove the feature or just removal of the button at least.

@BurakDev
Copy link

+1

@unknwon unknwon added the 🎯 feature Categorizes as related to a new feature label Oct 23, 2015
@unknwon unknwon modified the milestones: 0.7.0, 0.8.0 Oct 23, 2015
@faggy
Copy link

faggy commented Oct 28, 2015

? Why don't you just avoid clicking the button?!

@johnmaguire
Copy link
Contributor

I'm with @faggy on this one. It seems like settings UI clutter to add a checkbox for that. I'm not sure the maintenance or UI clutter of this is worth removing that tiny little button.

I don't know of any other Git management tools that offer the ability to disable pull requests.

You could always create a little Greasemonkey script (or even a Stylish profile) to hide the button.

@ChangePlaces
Copy link
Author

Settings ui clutter? You mean one checkbox is clutter to you? UI clutter? Uhm, this is about removing useless clutter from a single-dev perspective. Tiny button? it's kinda big.

why should gogs emulate other git management tools?

Or, I could make a suggestion as I'm sure other people will find it useful.

@tboerger
Copy link
Contributor

tboerger commented Nov 1, 2015

There are for sure projects that want to disable issues or pull requests

@unknwon
Copy link
Member

unknwon commented Nov 1, 2015

Disable issues/wiki/pull request , etc was on the todo actually.

@johnmaguire
Copy link
Contributor

Settings ui clutter? You mean one checkbox is clutter to you? UI clutter?

No need to be hostile. One option certainly isn't, the problem is it's a slippery slope. This blog post can explain it better than I can: http://swreflections.blogspot.com/2014/08/feature-toggles-are-one-of-worst-kinds.html

In any case, that was just my feelings on it. :)

@ChangePlaces
Copy link
Author

Sorry, I didn't mean to sound hostile!

@johnmaguire
Copy link
Contributor

🍻

@unknwon unknwon changed the title [feature request] Remove "Pull Request" option Remove "Pull Request" option Dec 5, 2015
@unknwon unknwon modified the milestones: 0.8.0, 0.8.x Dec 5, 2015
@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 5, 2015
@unknwon
Copy link
Member

unknwon commented Dec 5, 2015

OK, now possible to disable wiki/issues/pull requests on develop branch, test here: https://try.gogs.io/unknwon/Issue-1829

@unknwon unknwon closed this as completed in e538ff2 Dec 6, 2015
richmahn referenced this issue in unfoldingWord/dcs Jun 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Projects
None yet
Development

No branches or pull requests

6 participants