Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write UI in React.js #3226

Closed
DenisIzmaylov opened this issue Jul 1, 2016 · 7 comments
Closed

Re-write UI in React.js #3226

DenisIzmaylov opened this issue Jul 1, 2016 · 7 comments
Labels
⛔ do not send pull request Don't ever think about it! priority: maybe You know what, it sounds good

Comments

@DenisIzmaylov
Copy link

DenisIzmaylov commented Jul 1, 2016

Dear, nowadays React.js is close to be a standard for UI in JavaScript. It will takes a possibility to quick growth and cheap maintenance. A lot of already-done solutions with great quality.

@Xe
Copy link

Xe commented Jul 1, 2016

Gogs is not facebook, you don't need react. Even using jQuery can be overkill. Maintainers please ignore this ticket.

@DenisIzmaylov
Copy link
Author

So agressive.
React can provide extendable UI layer which allow to make Gogs is more like platform to customize according to business needs.

@unknwon unknwon added priority: maybe You know what, it sounds good ⛔ do not send pull request Don't ever think about it! labels Jul 2, 2016
@andreynering
Copy link
Contributor

andreynering commented Jul 2, 2016

I dislike this proposal. This would require more maintenance, and I am not sure of the benefits.

We have to remember that many people know HTML, but just a few know React. The may may be a barrier for new contributors.

It will takes a possibility to quick growth and cheap maintenance.

I don't think the statement above is true. I know React and it is not easy to learn for beginners. (This is why I prefer VueJS, but static HTML, when enough, is even better).

It's a possibility to add more interaction just to some pages, though.

@bkcsoft
Copy link
Contributor

bkcsoft commented Jul 3, 2016

When Gogs JSON-API is fullt implemented one could write their own frontend, so I'd push for that instead if I were you :)

@DenisIzmaylov
Copy link
Author

DenisIzmaylov commented Jul 4, 2016

Great!

Disagreed with those people who declined React.js because is really biggest UI ecosystem (have a look at jobs trends). React.js code is best for maintenance ever.

But it seems the best idea to keep MSA way. And seperate Gogs as a web service and UI service. Like Concourse.

@xor-gate
Copy link

xor-gate commented Aug 3, 2016

You cant just request a complete rewrite to a different framework because X or Y is better at A and B. This will take many many man hours. Keep in mind there are only a few core-developers with limited time.

@unknwon
Copy link
Member

unknwon commented Feb 24, 2017

I would rather write in VueJS... after 1.0 release...

@unknwon unknwon closed this as completed Feb 24, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⛔ do not send pull request Don't ever think about it! priority: maybe You know what, it sounds good
Projects
None yet
Development

No branches or pull requests

6 participants