Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

num_watchers not updated when adding a bare repository #819

Closed
klausenbusk opened this issue Jan 1, 2015 · 6 comments
Closed

num_watchers not updated when adding a bare repository #819

klausenbusk opened this issue Jan 1, 2015 · 6 comments
Labels
💊 bug Something isn't working

Comments

@klausenbusk
Copy link

  • Bug Description:
    If you add a repository (private or public, doesn't matter), the num_watchers in the database is not updated.. So if you unwatch, the number of watchers can be negative..
    See for yourself https://try.gogs.io/klausenbusk/test3 and https://try.gogs.io/klausenbusk/test4
  • Gogs Version: v0.5.9.1229 Beta
  • Git Version: 2.2.1
  • System Type: Arch Linux
  • Error Log: Nothing
  • Other information: Don't seems to happens, if you mark the "Initialize this repository with a README.md"..
psmit added a commit to psmit/gogs that referenced this issue Jan 2, 2015
@psmit
Fix gogs#819 by fetching the repository from db before updating
ca9855b
@unknwon unknwon added the 💊 bug Something isn't working label Jan 6, 2015
@unknwon
Copy link
Member

unknwon commented Jan 6, 2015

Hi @klausenbusk , can you check again see if problem is solved by above PR.

@klausenbusk
Copy link
Author

Hi @klausenbusk , can you check again see if problem is solved by above PR.

Sorry, haven't got time yet to try.. I will at some point! :)

@unknwon unknwon added the status: needs feedback Tell me more about it label Jan 17, 2015
@unknwon
Copy link
Member

unknwon commented Jan 17, 2015

@klausenbusk no problem, take your time.

unknwon added a commit that referenced this issue Feb 3, 2015
@unknwon
Merge pull request #821 from phsmit/fix_819
902f19f 
Fix #819 by fetching the repository from db before updating
@unknwon
Copy link
Member

unknwon commented Feb 3, 2015

You can test on https://try.gogs.io/ as well.

@unknwon unknwon changed the title num_watchers not updated when adding a repository num_watchers not updated when adding a bare repository Feb 3, 2015
@unknwon unknwon closed this as completed in 44fa914 Feb 3, 2015
@klausenbusk
Copy link
Author

I can confirm that it work now..

@unknwon
Copy link
Member

unknwon commented Feb 9, 2015

@klausenbusk thanks your confirm!

@unknwon unknwon removed the status: needs feedback Tell me more about it label Feb 9, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klausenbusk @unknwon