Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issue: support extra code generation for import public #22

Open
awalterschulze opened this issue Dec 3, 2014 · 1 comment
Open

Comments

@awalterschulze
Copy link
Member

From awalterschulze on August 07, 2014 13:59:23

protoc-gen-gogo/generator/helper.go

Add this method

func (d _FileDescriptor) AllMessages() []_Descriptor {
msgs := d.desc
for _, i := range d.imp {
obj, ok := i.o.(*Descriptor)
if ok {
msgs = append(msgs, obj)
}
}
return msgs
}

In each plugin there are gogoproto.Has/Is functions
At the moment they reference the current file, but they should reference the file in which the message/field was originally defined.

If the message was publicly imported its code generation should depend upon the file in which it was defined not the file which publicly imports it.

Most of it should work after this work is done.

Original issue: http://code.google.com/p/gogoprotobuf/issues/detail?id=22

@awalterschulze
Copy link
Member Author

From awalterschulze on August 07, 2014 05:00:08

If this is feature is important to you please comment so I can push up the priority.

@awalterschulze awalterschulze changed the title support extra code generation for import public Known Issue: support extra code generation for import public May 22, 2015
@awalterschulze awalterschulze removed the bug label Jun 2, 2015
@awalterschulze awalterschulze removed their assignment Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant