Pull request error

[renewsorensen]

Application Version: 0.7.6.1112 Beta

I have experienced a few issues with PR.
The first thing i see, is when i select develop branch on my forked repository, and press the PR button, it automatically selects base:master, which in my case is a branch that is 6 month behind the develop, so that takes a very long time to compare.

Next thing is if i want to change that, i change the base:master to base:develop

The url is weird

If i change the url manually it seems to do the right thing.

If i now do the pull request i just get the 500 error.

from the logs
2015/11/21 12:12:24 [...routers/repo/pull.go:642 CompareAndPullRequestPost()] [E] NewPullRequest: SavePatch: WriteFile: open g:\Git\scada\vob.server.git\pulls\1.patch: The system cannot find the path specified.
2015/11/21 12:12:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:12:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:12:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token

The last thing i see is that my log is filled with thees lines
2015/11/21 12:15:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:15:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:15:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:16:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:16:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:16:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:16:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:16:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:17:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:17:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:17:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:18:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:18:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:18:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:18:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:18:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:19:29 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:19:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token
2015/11/21 12:19:41 [...routers/repo/http.go:119 HTTP()] [E] invalid token

[stonerl]

Try to upgrade to the latest master there have been some PR related fixes.

[unknwon]

Thanks your feedback!

1. The error produced by manually change URL is not quite valid since many background work can not apply.
2. As @stonerl mentioned, there are a lot changes about PR after 0.7.6. please first test on https://try.gogs.io and then upgrade.

[renewsorensen]

Ok fair enough, i just tried different approaches to see if i could somehow get around that error.

i can confirm that i am not able to reproduce that particular error on https:/try.gogs.io.

I am not able to build (don't know how) go apps, so i wait for your next release.

[unknwon]

0.7.19 is already released.

[renewsorensen]

nice 👍 thanks!!

[unknwon]

I'm going to close this now, please reopen if problem still exits. 😷

[renewsorensen]

It was maybe unclear to me what was fixed in the current release, but after the upgrade to 0.7.19.1121 i still get the 400 if i change repo on one of the sides in PR