Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch API to ping OIDC endpoint to new model #14370

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

reasonerjt
Copy link
Contributor

This commit updates the API POST /api/v2.0/system/oidc/ping to new
programming model, in which the code will be generated by go-swagger.

Signed-off-by: Daniel Jiang jiangd@vmware.com

This commit updates the API POST /api/v2.0/system/oidc/ping to new
programming model, in which the code will be generated by go-swagger.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #14370 (e96c1cb) into master (d36994b) will increase coverage by 1.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14370      +/-   ##
==========================================
+ Coverage   62.94%   64.06%   +1.11%     
==========================================
  Files         915      915              
  Lines       61614    63486    +1872     
  Branches     2034     2034              
==========================================
+ Hits        38786    40674    +1888     
+ Misses      18886    18872      -14     
+ Partials     3942     3940       -2     
Flag Coverage Δ
unittests 64.06% <0.00%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/controllers/oidc.go 0.00% <ø> (ø)
src/pkg/oidc/helper.go 46.50% <ø> (ø)
src/pkg/oidc/secret.go 17.24% <ø> (ø)
src/pkg/oidc/testutils.go 100.00% <ø> (ø)
src/server/middleware/security/idtoken.go 22.58% <ø> (ø)
src/server/middleware/security/oidc_cli.go 78.12% <ø> (ø)
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/oidc.go 0.00% <0.00%> (ø)
src/pkg/scan/dao/scanner/registration.go 55.68% <0.00%> (-12.50%) ⬇️
src/jobservice/worker/cworker/c_worker.go 66.18% <0.00%> (-1.94%) ⬇️
... and 18 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 4c47b17 into goharbor:master Mar 5, 2021
@reasonerjt reasonerjt deleted the oidc-ping-refact branch September 21, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants