Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify usage of LDAP ping API on UI #14440

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

AllForNothing
Copy link
Contributor

Fixes: #14389
Signed-off-by: AllForNothing sshijun@vmware.com

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #14440 (adf9e16) into master (68d7c91) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14440      +/-   ##
==========================================
- Coverage   64.62%   64.61%   -0.02%     
==========================================
  Files         919      919              
  Lines       65133    65135       +2     
  Branches     2032     2034       +2     
==========================================
- Hits        42091    42085       -6     
- Misses      19080    19084       +4     
- Partials     3962     3966       +4     
Flag Coverage Δ
unittests 64.61% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...left-side-nav/config/auth/config-auth.component.ts 58.41% <20.00%> (-2.20%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 60.00% <0.00%> (-40.00%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️

Copy link
Contributor

@jwangyangls jwangyangls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI change related to LDAP ping
3 participants