Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to replication rules searching #14464

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

AllForNothing
Copy link
Contributor

Fixes: #14140
Signed-off-by: AllForNothing sshijun@vmware.com

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #14464 (8dcec04) into master (7694c13) will decrease coverage by 5.14%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14464      +/-   ##
==========================================
- Coverage   69.74%   64.60%   -5.15%     
==========================================
  Files         682      919     +237     
  Lines       53744    65147   +11403     
  Branches        0     2037    +2037     
==========================================
+ Hits        37482    42085    +4603     
- Misses      13011    19097    +6086     
- Partials     3251     3965     +714     
Flag Coverage Δ
unittests 64.60% <33.33%> (-5.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v/replication/replication/replication.component.ts 25.24% <0.00%> (ø)
...eplication-rule/list-replication-rule.component.ts 55.88% <100.00%> (ø)
src/controller/event/handler/auditlog/auditlog.go 57.89% <0.00%> (-5.27%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
...act/vulnerability-scanning/result-tip.component.ts 24.65% <0.00%> (ø)
...project/repository/gridview/grid-view.component.ts 26.13% <0.00%> (ø)
...nerabilities/artifact-vulnerabilities.component.ts 54.71% <0.00%> (ø)
...omponents/cron-schedule/cron-schedule.component.ts 27.45% <0.00%> (ø)
... and 232 more

Copy link
Contributor

@jwangyangls jwangyangls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search the replication policy by name missing pagination
3 participants