Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger tag retention API should be non-blocking #18504

Closed
chlins opened this issue Apr 10, 2023 · 5 comments · Fixed by #19533
Closed

Trigger tag retention API should be non-blocking #18504

chlins opened this issue Apr 10, 2023 · 5 comments · Fixed by #19533
Assignees
@chlins
Labels
area/tag-retention Issues relating to the tag retention policies features Stale target/2.10.0

Comments

@chlins
Copy link
Member

chlins commented Apr 10, 2023

How can we help you?

Currently the trigger tag retention API is blocked which will occur timeout if the project has huge repositories(tasks), should refactor this API to be asynchronously like replication and scanAll.
@chlins chlins self-assigned this Apr 10, 2023
@chlins chlins added the area/tag-retention Issues relating to the tag retention policies features label Apr 10, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2023
@chlins chlins removed the Stale label Jul 10, 2023
@chlins chlins reopened this Jul 10, 2023
@tecule
Copy link

tecule commented Aug 28, 2023

any progress on this issue? cause we find the "POST /api/v2.0/retentions/{id}/executions" api takes over 10s to handle thousands of repo.

@chlins
Copy link
Member Author

chlins commented Aug 28, 2023

any progress on this issue? cause we find the "POST /api/v2.0/retentions/{id}/executions" api takes over 10s to handle thousands of repo.

Target this issue to be resolved in the v2.10.0.

@github-actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Oct 27, 2023
@chlins chlins mentioned this issue Nov 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlins chlins

Labels
area/tag-retention Issues relating to the tag retention policies features Stale target/2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: optimize the trigger retention API chlins/harbor
2 participants
@tecule @chlins