New theme: Amperage #782
Comments
We already mention in the README that using a forward slash at the beginning of a URL will point to the host root. The same applies when one uses just |
Oh, I misread that part, I thought it was a url by it self what caused problems and if they were piped it was fine. One more thing, how should I approach a pagination demo? The paginator https://github.com/asurbernardo/amperage/blob/master/layouts/partials/page/pagination.html#L4 |
Hello @asurbernardo, thank you for sharing this theme with the Hugo community 👍 While looking at your theme I noticed that thumbnail ( |
Fixed! 👍 |
@onedrawingperday Urls are now fixed for the demo. 👍 I ended up passing an empty string and triming the default
It's not the most elegant solution IMO, so if you know a better way please let me know. |
@asurbernardo No. You do not need to use |
@onedrawingperday The thing is due to AMP requirements I need to generate absolute URLs on every link, so the internal pagination template doesn't help me because the That is why I do a |
@asurbernardo Ok. Since this is due to AMP requirements However I found the time to have a proper look at your theme and you need to do the following:
Currently as you have set up the menu in your theme demo:
You need to make sure to document this feature of your theme in the README so that users know about the detection of internal links for menu entries. Once you do the above please let me know. |
I've done the following:
Thank you so much for taking the time and for the thorough review! 😃 |
@asurbernardo I added your theme to the repo in 6efd432 This is a blog theme with AMP support. |
I've promoted your theme on Hugo's official Twitter account. |
@digitalcraftsman Thank you for the shout-out! I can't wait to get feature requests and new ideas to improve the theme. 😄 |
Theme submission
Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. Please tick the relevant boxes for your theme in the checklist below:
Link to my theme repository: https://github.com/asurbernardo/amperage
I made sure that...
README.md
describing my themeLICENSE.md
theme.toml
images/
folder with the required dimensionshttps://example.com
is set as base url inexampleSite/config.{toml, yaml, json}
to avoid the abuse of unused domainstoCSS
andPostCSS
that I have committed the/resources
directory with all generated assets, for my theme to work in the basic version of HugoN.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. You will need to keep an eye on whether your theme's demo generates on the Hugo website, whenever there is a new release. We are a very small team and we just cannot keep up opening issues in the various theme repositories to notify authors. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
Question:
I have noticed while building hugoThemes site to test the theme
$url | absURL
links work fine but$url | absLangURL
links refer to the root domain instead of the theme subfolder. Does this have anything to do with my project? 🤔The text was updated successfully, but these errors were encountered: