Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow shows lots of errors related to react-navigation #10

Open
brettdh opened this issue Jan 7, 2018 · 0 comments
Open

Flow shows lots of errors related to react-navigation #10

brettdh opened this issue Jan 7, 2018 · 0 comments
Labels
on hold Issues that shouldn't be picked up until some other condition is resolved.

Comments

@brettdh
Copy link
Contributor

brettdh commented Jan 7, 2018

Note: Waiting on fixing this for now, pending a response to my comment here on a PR that removed flow from react-navigation.

Expected behavior

Flow reports no errors.

Actual behavior

Flow reports 141 errors, the first 50 of which are displayed. They all seem to be related to react-navigation. (It may seem surprising that flow is checking anything in node_modules/**, but it would seem that it checks things that we import.

Steps to reproduce the problem

  1. yarn flow

Environment

  • App version (or commit SHA): 3419418fc9ea4f1639dc094be9fb505f32d3bccd
  • Dev environment:
➜ node --version
v8.8.1
➜ yarn --version 
1.1.0
➜ yarn flow version  
yarn run v1.1.0
$ flow "version"
Flow, a static type checker for JavaScript, version 0.53.0
✨  Done in 0.18s.
➜ grep -A3 version .flowconfig
[version]
^0.53.0
@brettdh brettdh added this to To Do in User Stories and Bugs Jan 10, 2018
@brettdh brettdh self-assigned this Jan 25, 2018
@brettdh brettdh moved this from To Do to In progress in User Stories and Bugs Jan 25, 2018
@brettdh brettdh moved this from In progress to To Do in User Stories and Bugs Jan 25, 2018
@brettdh brettdh removed their assignment Jan 25, 2018
@brettdh brettdh added the on hold Issues that shouldn't be picked up until some other condition is resolved. label Jan 25, 2018
@brettdh brettdh removed this from To Do in User Stories and Bugs Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Issues that shouldn't be picked up until some other condition is resolved.
Projects
None yet
Development

No branches or pull requests

1 participant