Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.URL escaped path not present in go 1.4 which AppEngine uses #14

Closed
crewjam opened this issue Jan 18, 2016 · 5 comments
Closed

url.URL escaped path not present in go 1.4 which AppEngine uses #14

crewjam opened this issue Jan 18, 2016 · 5 comments

Comments

@crewjam
Copy link

crewjam commented Jan 18, 2016

I'm not sure what the version support targets are, but it appears that net/url:URL EscapedPath() is not present in go1.4 which is used by AppEngine. I'd be happy to work on a PR if you'd like.

@zenazn
Copy link
Member

zenazn commented Jan 18, 2016

This version of Goji is 1.5+, both for EscapedPath and because go get goji.io won't work in 1.4

@zenazn
Copy link
Member

zenazn commented Jan 27, 2016

I'm going to close this issue since Goji is working as intended, but if AppEngine continues to not support Go 1.5 for an extended period it might be worth maintaining a branch with hacked together 1.4 compatibility.

@zenazn zenazn closed this as completed Jan 27, 2016
@keighl
Copy link

keighl commented Mar 15, 2016

GAE recently released a go1.6beta runtime. I'm hoping it does the trick.

# app.yaml
api_version: go1.6beta

@keighl
Copy link

keighl commented Mar 15, 2016

... however, there's no 1.6 support in the SDK yet, so it can't be run locally.

@keighl
Copy link

keighl commented Apr 2, 2016

GAE 1.6 support arrived finally:

https://cloud.google.com/appengine/downloads#Google_App_Engine_SDK_for_Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants