Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go modules support ? #58

Closed
ekle opened this issue Nov 8, 2018 · 5 comments
Closed

go modules support ? #58

ekle opened this issue Nov 8, 2018 · 5 comments

Comments

@ekle
Copy link

ekle commented Nov 8, 2018

the new go modules allow to fetch versions with go get.
but this does not seem to work:

go get goji.io@v1.1
go get goji.io@v1.1: no matching versions for query "v1.1"
@elithrar
Copy link
Member

elithrar commented Nov 8, 2018

You can only fetch a Go package by its version if it explicitly defines itself as a valid Go Module - through the presence of a valid go.mod file.

Goji isn’t a yet Module (Modules aren’t final yet), and thus you can’t use go get like that.

@zenazn
Copy link
Member

zenazn commented Nov 11, 2018

Good news! Just added module support. Let me know if you’re still having trouble with this

@zenazn zenazn closed this as completed Nov 11, 2018
@ekle
Copy link
Author

ekle commented Nov 12, 2018

hi,
it still does not work. But i think that is because of the git-tags.
go modules requires vX.Y.Z tags. it looks like it does not work with vX.Y tags.

GO111MODULE=on go get -u -v goji.io@v1.1
  Fetching https://goji.io?go-get=1
  Parsing meta tags from https://goji.io?go-get=1 (status code 200)
  get "goji.io": found meta tag get.metaImport{Prefix:"goji.io", VCS:"git", 
  RepoRoot:"https://github.com/goji/goji"} at https://goji.io?go-get=1
  go get goji.io@v1.1: no matching versions for query "v1.1"

@zenazn
Copy link
Member

zenazn commented Nov 13, 2018

Alright—I’ve gone and added three-part semvar tags. Let me know if that helps!

@zenazn zenazn reopened this Nov 13, 2018
@ekle
Copy link
Author

ekle commented Nov 13, 2018

thx, now it works :)

@ekle ekle closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants