Separate instantiation from showing the view. Otherwise it can happen… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that you end up in a situation where the UI is blocked
Esqarrouth
added a commit
that referenced
this pull request
Jan 19, 2016
Separate instantiation from showing the view. Otherwise it can happen…
|
Good catch, thanks man 👍 |
|
Actually it was a problem that I had :-) Could u please update it on cocoapods too? thanks On Wed, Jan 20, 2016 at 12:19 AM, Goktug Yilmaz notifications@github.com
|
|
I will update the pods tomorrow, hope you're not in a hurry |
|
Sorry for late update. I updated the repo now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… that you end up in a situation where the UI is blocked.
In the original version where instantiation and showing is done in one step (dispatch main) it can be that the dispatch didn't occur when you call the hide method. Hide is checking as a first step if there is an instance, which is not, because the main thread didn't elaborate it yet, and exits.
Then at a point in time the main thread is showing the Indicator with blocking id, and never gets dismissed.
With this change the instance is there, even if it hasn't been shown and as both showing and hiding happen in the same thread (main) it will be shown and immediately hidden, and the UI is unblocked.