Uiview fade animate #299
Uiview fade animate #299
Conversation
Generated by 🚫 danger |
Current coverage is 36.60% (diff: 100%)@@ master #299 diff @@
==========================================
Files 46 46
Lines 2042 2076 +34
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 714 760 +46
+ Misses 1328 1316 -12
Partials 0 0
|
| ///EZSE: Fade in with duration, delay and completion block. | ||
| public func fadeIn(_ duration:TimeInterval?, delay _delay:TimeInterval?, completion: ((Bool) -> Void)? = nil) { | ||
| UIView.animate(withDuration: duration ?? UIViewFadeDuration, delay: _delay ?? 0.0, options: UIViewAnimationOptions(rawValue: UInt(0)), animations: { | ||
| self.alpha = 0 |
There was a problem hiding this comment.
You would say fadeIn = alpha 1.0, and fadeOut = alpha 0.0?
| if let completion = completion { | ||
| completion(success) | ||
| } | ||
| } |
There was a problem hiding this comment.
It's better that completion set to UIView.animate func directly.
}, completion: completion)
|
|
||
| extension UIView { | ||
| ///EZSE: Fade in with duration, delay and completion block. | ||
| public func fadeIn(_ duration:TimeInterval?, delay _delay:TimeInterval?, completion: ((Bool) -> Void)? = nil) { |
There was a problem hiding this comment.
I think it's better to use Default Parameter Values
There was a problem hiding this comment.
In my case we can use the function like this aView.fadeIn(nil, delay: 1.0, completion: nil) the nil values will be Default Parameter Values, but we lost the aView.fadeIn() definition. However I'll re-write function as you think.
Thanks.
| Easily to fade in/out or a specific alpha value with completion blocks: | ||
|
|
||
| ``` swift | ||
| view.fadeInWithDuration(0.5, delay: 1.0) { (success) in |
There was a problem hiding this comment.
Could you please describe the correct usage?
|
Could you fix swiftlint warnings? |
|
Thanks for contributing, @vilapuigvila! 😃 👍 |
| completion(success) | ||
| } | ||
| } | ||
| public func fadeIn(_ duration:TimeInterval? = UIViewFadeDuration, delay _delay:TimeInterval? = 0.0, completion: ((Bool) -> Void)? = nil) { |
There was a problem hiding this comment.
duration and delay should not be Optional.
Because, if user set nil to duration or delay, application crashes.
There was a problem hiding this comment.
Glups.. eventually I've keep both, I think will be more useful. We can implement view.fadeIn() or view.fadeIn(nil, delay: 1.5, completion: nil) and much more.
There was a problem hiding this comment.
Ummm.. I think that omitting the unnecessary parameters is enough for users.
and, To match implementation with other methods is important.
What do you guys think?
|
@vilapuigvila Thanks for fixing and good extensions 😄 |
|
@vilapuigvila can you please add tests for this one too? |
|
@lfarah Of course, this week I don't have much time, I'm very busy, I'll try this night. |
|
@lfarah Since we're redoing the readme, is it wise to add the new examples to the old readme? |
|
@goktugyil we're only adding important ones and not every single one |
|
@goktugyil I don't think we should add new examples to old readme |
| func testFadeOut() { | ||
|
|
||
| let view = UIView() | ||
| view.alpha = 0.0 |
There was a problem hiding this comment.
This value should not be 0.
|
@lfarah This commit has an entry to the readme |
|
@vilapuigvila can you please remove it? |
|
Removed. |
|
Thanks for all the patience, @vilapuigvila and thanks to @furuyan for the code reviews! |
Checklist