Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A shorter release this time? #388

Closed
Khalian opened this issue Feb 19, 2017 · 11 comments
Closed

A shorter release this time? #388

Khalian opened this issue Feb 19, 2017 · 11 comments

Comments

@Khalian
Copy link
Collaborator

Khalian commented Feb 19, 2017

Our last release took longer. IMO releases should be frequent for OSS projects to formalize recent changes.

We have had some decent set of features of going in till now (not as much as 1.8 though). Would the maintainers be interested in releasing now ?

@Esqarrouth
Copy link
Owner

Am I the only one who can push a new release? I think at least in cocoapods I'm the only one, but I think I can add other maintainers too.

@piv199 @lfarah

Ready for release, agree/disagree?

@lfarah
Copy link
Collaborator

lfarah commented Feb 19, 2017

I also agree we took to long to push a new release. You can also add us as mainteiners

@lfarah
Copy link
Collaborator

lfarah commented Feb 19, 2017

Just so we're organized, can we add things to 1.9?

@lfarah
Copy link
Collaborator

lfarah commented Feb 19, 2017

@Khalian did I miss anything? If not, please make a PR changing the CHANGELOG.md to 1.9 and add a 1.9 tag, so @goktugyil can push it to CocoaPods

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 19, 2017

Yeah, that should we about it, I will try to post out the fixes and update the changelog and send a CR. Also tag the release to 1.9.

@lfarah
Copy link
Collaborator

lfarah commented Feb 19, 2017

Perfect. Thanks @Khalian 👍

@Esqarrouth
Copy link
Owner

Esqarrouth commented Feb 21, 2017

@lfarah You have pod access now, you should push 1.9 to see if things are working.

Heres a checklist: https://github.com/thellimist/EZPods

@Khalian @piv199

I got this error message:

[!] No owner found with the specified email address.

Its probably because you don't have a library or registered in cocoapods.

@piv199
Copy link
Collaborator

piv199 commented Feb 21, 2017

I haven't been watching for a while, so I can't tell about release :) If it's needed then do.
I wish I could blend in the project asap. I was really missing the open source.

@Khalian Khalian closed this as completed Feb 25, 2017
@Esqarrouth
Copy link
Owner

@lfarah we need a pod release

@lfarah
Copy link
Collaborator

lfarah commented Mar 1, 2017

screen shot 2017-03-01 at 6 40 51 pm

giphy 22

@lfarah
Copy link
Collaborator

lfarah commented Mar 1, 2017

@Khalian we have a problem tho: we forgot to update the podspec, so we gotta remove tag 1.9 and add it again since we need to add this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants