New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Description> : Release candidate for v1.9 #390
Conversation
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 39.52% 39.27% -0.26%
==========================================
Files 47 47
Lines 2168 2182 +14
==========================================
Hits 857 857
- Misses 1311 1325 +14
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
|
||
1. **Array** | ||
- `foreach` is now removed since its already in the std library by *Khalian* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add removeAll
removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
<Type> : release
removalAll still looks to be on master. |
@DanielAsher I am aware of that. When I rebase and merge it, master will replay against it and this commit would be on top of the removeAll commit. |
@Khalian great, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where depreceated/renamed/modified extensiosn?
"Where depreceated/renamed/modified extensiosn?" Should I include the commit ID or the PR for the modifications ? This wasnt the case for the CHANGELOG entries for the prior release. |
@goktugyil Can I go ahead with the merge ? |
ok |
@Khalian "When I rebase and merge it, master will replay against it and this commit would be on top of the removeAll commit." |
@Khalian as I mentioned in #392 (and requested review) Perhaps I'm confused, if so apologies. |
: release
Checklist