Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Description> : Release candidate for v1.9 #390

Merged
merged 1 commit into from Feb 25, 2017
Merged

<Description> : Release candidate for v1.9 #390

merged 1 commit into from Feb 25, 2017

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Feb 20, 2017

: release

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Feb 20, 2017

2 Messages
📖 Executed 180 tests, with 0 failures (0 unexpected) in 6.988 (7.265) seconds
📖 Executed 166 tests, with 0 failures (0 unexpected) in 5.447 (5.724) seconds

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Feb 20, 2017

Codecov Report

Merging #390 into master will decrease coverage by -0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   39.52%   39.27%   -0.26%     
==========================================
  Files          47       47              
  Lines        2168     2182      +14     
==========================================
  Hits          857      857              
- Misses       1311     1325      +14
Impacted Files Coverage Δ
Sources/ArrayExtensions.swift 73.91% <ø> (-8.35%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec0a97...5d96c8d. Read the comment docs.

CHANGELOG.md Outdated

1. **Array**
- `foreach` is now removed since its already in the std library by *Khalian*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add removeAll removal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 22, 2017

@piv199 @goktugyil ?

@DanielAsher
Copy link

removalAll still looks to be on master.

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 22, 2017

@DanielAsher I am aware of that. When I rebase and merge it, master will replay against it and this commit would be on top of the removeAll commit.

@DanielAsher
Copy link

@Khalian great, thanks.

Copy link
Owner

@Esqarrouth Esqarrouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where depreceated/renamed/modified extensiosn?

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 22, 2017

"Where depreceated/renamed/modified extensiosn?"

Should I include the commit ID or the PR for the modifications ? This wasnt the case for the CHANGELOG entries for the prior release.

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 24, 2017

@goktugyil Can I go ahead with the merge ?

@Esqarrouth
Copy link
Owner

ok

@DanielAsher
Copy link

@Khalian "When I rebase and merge it, master will replay against it and this commit would be on top of the removeAll commit."
removeAll is still in the codebase. could you link to the commit hash that you reference in your comment.

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 25, 2017

dec0a97

@Khalian Khalian dismissed Esqarrouth’s stale review February 25, 2017 17:55

Discussed as not important

@Khalian Khalian merged commit 0b22000 into master Feb 25, 2017
@Khalian Khalian deleted the release_1.9 branch February 25, 2017 17:56
@DanielAsher
Copy link

@Khalian as I mentioned in #392 (and requested review) removeAll is not correctly removed from ArrayExtensions.swift as can be seen here: https://github.com/goktugyil/EZSwiftExtensions/blob/master/Sources/ArrayExtensions.swift#L136

Perhaps I'm confused, if so apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants