Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for VerifyExpiresAt, VerifyNotBefore and VerifyIssuedAt is incorrect #71

Closed
lggomez opened this issue Aug 3, 2021 · 1 comment · Fixed by #83
Closed

Documentation for VerifyExpiresAt, VerifyNotBefore and VerifyIssuedAt is incorrect #71

lggomez opened this issue Aug 3, 2021 · 1 comment · Fixed by #83
Labels
bug Something isn't working documentation Improvements or additions to documentation jwt-go: legacy

Comments

@lggomez
Copy link
Member

lggomez commented Aug 3, 2021

Migrated from dgrijalva/jwt-go#360:

nathan-fiscaletti commented on Sep 28, 2019

The VerifyExpiresAt function for Claims has incorrect or unclear documentation. It states that it will compare the exp claim to cmp, which is indicative of a == comparison, when in reality it does a cmp <= exp comparison.
@lggomez
Copy link
Member Author

lggomez commented Aug 3, 2021

nathan-fiscaletti commented on Sep 29, 2019

The same goes for VerifyNotBefore and VerifyIssuedAt

@lggomez lggomez added bug Something isn't working documentation Improvements or additions to documentation jwt-go: legacy labels Aug 3, 2021
This was referenced Aug 3, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation jwt-go: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jwt: Fix Verify methods documentation golang-jwt/jwt
1 participant
@lggomez