Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate command to the path in the Docker image #304

Closed
mrosales opened this issue Nov 20, 2019 · 2 comments
Closed

Add migrate command to the path in the Docker image #304

mrosales opened this issue Nov 20, 2019 · 2 comments

Comments

@mrosales
Copy link

Is your feature request related to a problem? Please describe.
When using the docker image, either for interactive purposes or for something like a CI runtime, it is often helpful to override the entrypoint and just run the container using with a shell entrypoint. It would be nice to have the migrate binary linked on the path so it can be executed with migrate rather than /migrate.

Describe the solution you'd like
In order to avoid breaking backwards compatibility the cleanest solution is probably just to link the /migrate binary to /usr/bin in case anyone depends on the file being saved at the current location.

Are there any objections to this or was there a reason to avoid placing the binary on the path to begin with?

@dhui
Copy link
Member

dhui commented Nov 21, 2019

Are there any objections to this or was there a reason to avoid placing the binary on the path to begin with?

No objections. I believe/migrate was used for simplicity. Also, I wouldn't count on a shell being available in the docker image. In the future, we might use a scratch docker image.

Feel free to open a PR w/ your suggested change!

@dhui
Copy link
Member

dhui commented Mar 15, 2020

Fixed in v4.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants