New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding support for 'IMAGE:' #517

Open
sbinet opened this Issue Oct 11, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@sbinet
Member

sbinet commented Oct 11, 2017

like for the tour and the playground which have support for displaying images, it would be great if gddo and godoc -http had support for displaying images (PNG,JPEG and, possibly, SVG).

this would be extremely useful for examples.

see:
https://play.golang.org/p/cDHAf2FuFa

@eaburns @kortschak @btracey

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 12, 2017

Member

Where would gddo display images? I don't quite understand.

Member

dmitshur commented Oct 12, 2017

Where would gddo display images? I don't quite understand.

@sbinet

This comment has been minimized.

Show comment
Hide comment
@sbinet

sbinet Oct 12, 2017

Member

the idea was to be able to display them as part of ExampleFoo.
e.g. the Example for the image package:
https://godoc.org/image#example-package
https://play.golang.org/p/ulqUiz2Yi3

could be modified to display the input image:
https://play.golang.org/p/j6arjYX9my

(I have removed the printouts of the histograms as the IMAGE: "plugin" doesn't trigger otherwise)

Member

sbinet commented Oct 12, 2017

the idea was to be able to display them as part of ExampleFoo.
e.g. the Example for the image package:
https://godoc.org/image#example-package
https://play.golang.org/p/ulqUiz2Yi3

could be modified to display the input image:
https://play.golang.org/p/j6arjYX9my

(I have removed the printouts of the histograms as the IMAGE: "plugin" doesn't trigger otherwise)

@sbinet

This comment has been minimized.

Show comment
Hide comment
@sbinet

sbinet Oct 12, 2017

Member

gddo would display the image "inline" in the godoc example div as part of the // Output: gimmick.

Member

sbinet commented Oct 12, 2017

gddo would display the image "inline" in the godoc example div as part of the // Output: gimmick.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 12, 2017

Member

I understand now, thanks for clarifying.

Member

dmitshur commented Oct 12, 2017

I understand now, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment