Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

consider adding support for 'IMAGE:' #517

Open
sbinet opened this issue Oct 11, 2017 · 4 comments
Open

consider adding support for 'IMAGE:' #517

sbinet opened this issue Oct 11, 2017 · 4 comments

Comments

@sbinet
Copy link
Member

sbinet commented Oct 11, 2017

like for the tour and the playground which have support for displaying images, it would be great if gddo and godoc -http had support for displaying images (PNG,JPEG and, possibly, SVG).

this would be extremely useful for examples.

see:
https://play.golang.org/p/cDHAf2FuFa

@eaburns @kortschak @btracey

@dmitshur
Copy link
Contributor

Where would gddo display images? I don't quite understand.

@sbinet
Copy link
Member Author

sbinet commented Oct 12, 2017

the idea was to be able to display them as part of ExampleFoo.
e.g. the Example for the image package:
https://godoc.org/image#example-package
https://play.golang.org/p/ulqUiz2Yi3

could be modified to display the input image:
https://play.golang.org/p/j6arjYX9my

(I have removed the printouts of the histograms as the IMAGE: "plugin" doesn't trigger otherwise)

@sbinet
Copy link
Member Author

sbinet commented Oct 12, 2017

gddo would display the image "inline" in the godoc example div as part of the // Output: gimmick.

@dmitshur
Copy link
Contributor

I understand now, thanks for clarifying.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants