Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2: reflect/prototype: decide representation of repeated fields in Extension.GoType #901

Closed
dsnet opened this issue Jul 16, 2019 · 1 comment
Closed

APIv2: reflect/prototype: decide representation of repeated fields in Extension.GoType #901

dsnet opened this issue Jul 16, 2019 · 1 comment

Comments

@dsnet
Copy link
Member

dsnet commented Jul 16, 2019

The documented representation for a repeated extension is a *[]T instead of []T. This is done so that the interface{} representation of a repeated field can implemented the full feature set of a protoreflect.List.

However, a *[]T is cumbersome to work with. Consider switching this to be []T instead.
@dsnet dsnet added this to the v2 release milestone Aug 21, 2019
@neild
Copy link
Contributor

neild commented Sep 3, 2019

https://golang.org/cl/192458 changes this to []T. Many yaks were shaved to bring us this change.

@neild neild closed this as completed Sep 3, 2019
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neild @dsnet