-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No-statement breakpoints are marked as valid #1999
Comments
Please see #1840 One way to verify breakpoints is to use |
a follow-up question: if the |
Another thought:
This specific case is clearly an error that belongs to this debug session because the source file is valid, but it's a line that can't be used for breakpoint. In this case, wonder if we can output an error message.
There are so many optional properties that adding all of them in the template would be confusing. Then the question will be whether we should consider |
We will investigate if we can distinguish the root cause and try to output error message in this specific case (where breakpoint in non-statement line) first. --
Actually, dlv dap reports back the list of invalid breakpoints to the editor but VS Code clears the info as soon as the debug session ends. :-( |
We talked about printing to console in #1840, but there were concerns of spamming with irrelevant messages.
If you use |
What version of Go, VS Code & VS Code Go extension are you using?
Version Information
go version
to get version of Go from the VS Code integrated terminal.go version go1.17.5 darwin/amd64
gopls -v version
to get version of Gopls from the VS Code integrated terminal.code -v
orcode-insiders -v
to get version of VS Code or VS Code Insiders.v0.30.0
Go: Locate Configured Go Tools
command.Share the Go related settings you have added/edited
(there's none)
Describe the bug
there is no persistent indication that a breakpoint is set on a line without any statement.
Steps to reproduce the behavior:
from the editor, there is no indication that the breakpoint will not be accepted by
dlv
:the breakpoint is displayed as valid (bright red)
during the debug run, it flashes white very briefly, but is silently skipped. there is zero diagnostic from
dlv
:output from the debug console
meanwhile,
dlv
informs me when I run it manually that a breakpoint is invalid:The text was updated successfully, but these errors were encountered: