Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Govulncheck command execution should be cancellable #2185

Closed
hyangah opened this issue Apr 15, 2022 · 1 comment
Closed

Govulncheck command execution should be cancellable #2185

hyangah opened this issue Apr 15, 2022 · 1 comment
Labels
FrozenDueToAge gopls gopls related issues vulncheck or vulndb Issues for vulncheck functionality
Milestone
v0.34.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 15, 2022

We need to pass Context given in
https://github.com/golang/tools/blob/884ffcdf166f9ee4133a974a6f996d551c8a8bbb/gopls/internal/vulncheck/command.go#L81

when

  • loading packages.
  • retrieving vulnerability info from vulndb.
  • running vulncheck.Source.

cc @zpavlinovic @suzmue @jamalc @findleyr
@hyangah hyangah added vulncheck or vulndb Issues for vulncheck functionality gopls gopls related issues labels Apr 15, 2022
@gopherbot gopherbot added this to the Untriaged milestone Apr 15, 2022
@findleyr findleyr modified the milestones: Untriaged, On Deck Apr 20, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/404576 mentions this issue: src/goVulncheck: replace gopls custom command with gopls vulncheck``

@hyangah hyangah modified the milestones: vscode-go/later, v0.34.0 May 23, 2022
@golang golang locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls gopls related issues vulncheck or vulndb Issues for vulncheck functionality
Projects
None yet
Milestone
v0.34.0
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @findleyr