Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulncheck command line should report progress #2186

Closed
hyangah opened this issue Apr 15, 2022 · 1 comment
Closed

Vulncheck command line should report progress #2186

hyangah opened this issue Apr 15, 2022 · 1 comment
Labels
FrozenDueToAge gopls gopls related issues vulncheck or vulndb Issues for vulncheck functionality
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 15, 2022

There is currently no feedback on what the command is doing.
Consider passing cfg.progress in https://github.com/golang/tools/blob/b2552ef554f216cb7c6b475538301c39fb1571e1/internal/lsp/command.go#L797 to opts.Hooks.Govulncheck, and report progress (at least whether we are loading packages, how many packages were loaded, whether we are checking vulndb, whether we started to call vulncheck API, ...)

As we do this, consider logging the time spent in each step to help debugging the performance.

@hyangah hyangah added gopls gopls related issues vulncheck or vulndb Issues for vulncheck functionality labels Apr 15, 2022
@gopherbot gopherbot added this to the Untriaged milestone Apr 15, 2022
@findleyr findleyr modified the milestones: Untriaged, On Deck Apr 20, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/404576 mentions this issue: src/goVulncheck: replace gopls custom command with gopls vulncheck``

@hyangah hyangah modified the milestones: vscode-go/later, v0.34.0 May 23, 2022
@golang golang locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls gopls related issues vulncheck or vulndb Issues for vulncheck functionality
Projects
None yet
Development

No branches or pull requests

3 participants