Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: investigate inline mode debug adapter #232

Closed
hyangah opened this issue Jun 16, 2020 · 2 comments
Closed

debug: investigate inline mode debug adapter #232

hyangah opened this issue Jun 16, 2020 · 2 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 16, 2020

From #23 (comment)

The debug adapter library allows three different modes of launching the debug adapter.
https://github.com/microsoft/vscode-mock-debug/blob/master/src/extension.ts#L57

In particular the inline mode is interesting. Explore and see if it's better for long term.

@eliben already has a prototype that wires the existing GoDebugSession in the inline mode.
https://github.com/eliben/vscode-go/commit/81042e0e813f781bb0e5d6eeb747834bb21d6d97

@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Jun 16, 2020
@eliben
Copy link
Member

eliben commented Jul 6, 2020

FWIW, the new DA (debugAdapter2) works in inline mode.

@hyangah hyangah added this to the Backlog milestone Aug 7, 2020
@hyangah hyangah added this to Needs triage in Debug Sep 17, 2020
@hyangah hyangah moved this from Needs triage to Low priority in Debug Sep 17, 2020
@hyangah
Copy link
Contributor Author

hyangah commented Sep 22, 2021

Closing because this is no longer relevant. We will leave the legacy debug adapter as it is.
The new dlv dap adapter is integrated through an inline-mode thin adapter.

@hyangah hyangah closed this as completed Sep 22, 2021
Debug automation moved this from Low priority to Closed Sep 22, 2021
@golang golang locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
No open projects
Debug
  
Closed
Development

No branches or pull requests

3 participants