Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Esbuild dependency to support building on s390x #2668

Closed
SDawley opened this issue Feb 16, 2023 · 2 comments
Closed

Update Esbuild dependency to support building on s390x #2668

SDawley opened this issue Feb 16, 2023 · 2 comments
Assignees
@jamalc
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
vscode-go/backlog

Comments

@SDawley
Copy link

SDawley commented Feb 16, 2023

Is your feature request related to a problem? Please describe.
Currently vscode-go is dependent on "esbuild": "0.12.21", which pulls in platform specific binaries when it installs, but there isnt a exbuild-linux-s390x binary for this version.

Describe the solution you'd like
s390x was added in 0.14.8, so if the dependency could be updated to at least that version it would be appreciated.

Thanks!
@gopherbot gopherbot added this to the Untriaged milestone Feb 16, 2023
@jamalc jamalc added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 16, 2023
@jamalc jamalc modified the milestones: Untriaged, vscode-go/later Feb 16, 2023
@jamalc jamalc self-assigned this Feb 16, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/469915 mentions this issue: package.json: upgrade esbuild

@SDawley
Copy link
Author

SDawley commented Feb 22, 2023

Thank you!

@golang golang locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
vscode-go/backlog
Development

No branches or pull requests
3 participants
@gopherbot @jamalc @SDawley