Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache upload hangs for 2 minutes after work is done #984

Closed
3 tasks done
DavidS-ovm opened this issue Feb 23, 2024 · 2 comments · Fixed by #1024
Closed
3 tasks done

cache upload hangs for 2 minutes after work is done #984

DavidS-ovm opened this issue Feb 23, 2024 · 2 comments · Fixed by #1024

Comments

@DavidS-ovm
Copy link

DavidS-ovm commented Feb 23, 2024

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Description of the problem

The action hangs for 2 minutes after uploading the cache for no apparent reason.

See this example from the golanci-lint main repo:

2024-02-23_09MS+0100_1416x524

  • This is not specific to golangci/golangci-lint setup, I've originally found this in my repos.
  • When re-running the job (in my repo), the cache does not get uploaded and the delay vanishes.

Version of golangci-lint

golangci-lint-1.56.2-linux-amd64

Version of the GitHub Action

v4.0.0

Workflow file

see https://github.com/golangci/golangci-lint/actions/runs/8005893870/workflow

Go version

go version go1.22.0 linux/amd64

Code example or link to a public repository

https://github.com/golangci/golangci-lint

@ankon
Copy link

ankon commented Feb 29, 2024

I'm seeing the same behavior, the action is configured as:

      - name: Lint
        uses: golangci/golangci-lint-action@v4
        with:
          version: latest
          # Use the existing caches for ~/go/pkg/mod and ~/.cache/go-build
          skip-pkg-cache: true
          skip-build-cache: true
          # Bump the timeout to reduce build flakiness
          args: --timeout=120s

@JeffreyTheTukkr
Copy link

Exactly the same issue here with a nearly empty project.

image

ci.yaml

jobs:
  linting:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-go@v5
        with:
          go-version: '1.21'
          cache: false
      - uses: golangci/golangci-lint-action@v4
        with:
          version: v1.56
      - run: golangci-lint run ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants