Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support staticcheck configuration #1275

Closed
benjaminjkraft opened this issue Jul 27, 2020 · 1 comment · Fixed by #2017
Closed

support staticcheck configuration #1275

benjaminjkraft opened this issue Jul 27, 2020 · 1 comment · Fixed by #2017
Labels
enhancement New feature or improvement

Comments

@benjaminjkraft
Copy link

Staticcheck has a bunch of options. We'd like to be able to use those via golangci-lint, but it doesn't seem to be supported.

It's not clear to me if staticcheck exposes a proper way to do this, but it looks like setting DefaultConfig would be a plenty usable hack.

I think this would subsume #649, #980, perhaps others.

@benjaminjkraft benjaminjkraft added the enhancement New feature or improvement label Jul 27, 2020
@csilvers
Copy link
Contributor

It looks like staticcheck-in-the-context-of-golangci-lint reads the staticcheck.conf file, so another usable hack is to just set that. It's not great to have two config files but it's better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants