Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultExcludePatterns should only be used for specified linter #1474

Closed
zhangyunhao116 opened this issue Oct 30, 2020 · 1 comment · Fixed by #1494
Closed

DefaultExcludePatterns should only be used for specified linter #1474

zhangyunhao116 opened this issue Oct 30, 2020 · 1 comment · Fixed by #1494
Labels
bug Something isn't working

Comments

@zhangyunhao116
Copy link
Member

golangci-lint set --exclude-use-default=true by default, but the exclude pattern is used for global match but not for specified linter(we can see the linter in pkg/config/config.go). I develop a new linter, one rule just check whether there is at least one package comment in a Go package, but the issue match EXC0002 for golint, so it is ignored by default.

I think we can make some changes to the processor in pkg/result/processors/exclude_rules.go, so that it can handle both exclude global match and exclude specified match for some linters.

@zhangyunhao116 zhangyunhao116 added the bug Something isn't working label Oct 30, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 30, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant