Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent option is not settable through config file #159

Closed
dmoklaf opened this issue Jul 15, 2018 · 3 comments
Closed

silent option is not settable through config file #159

dmoklaf opened this issue Jul 15, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@dmoklaf
Copy link

dmoklaf commented Jul 15, 2018

The silent option is not illustrated in the sample configuration file.

Setting it in the configuration file (in the run section) has no effect.

@jirfag jirfag added the bug Something isn't working label Jul 25, 2018
@sendilkumarn
Copy link

Setting this in run section actually works. (It will not work when it is in output I guess, but logically shouldn't it be there? )

@dmoklaf
Copy link
Author

dmoklaf commented Jul 26, 2018

That depend completely on your use of the tool.

In our case (we are command line guys), this forced us to wrap the golangci binary in a script, just to set silent. The configuration file was great because it allowed to hide all these command line details. Excepted silent.

Also, the documentation states that everything that can be modified through the command line can be set through the configuration file. silent is an exception to this simple rule. If it is kept as an exception, that shall be documented. But it may be just simpler to simplify things and make it configurable too.

In all cases, thanks for this outstanding tool. A lot of care has been brought in optimizing things, and it shows.

@jirfag
Copy link
Member

jirfag commented Jul 29, 2018

hi!
the option can be set in run section, I've added it to documentation and .golangci.example.yml, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants