Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin option for Goland #1720

Merged
merged 1 commit into from Feb 8, 2021
Merged

Add plugin option for Goland #1720

merged 1 commit into from Feb 8, 2021

Conversation

xxpxxxxp
Copy link
Contributor

@xxpxxxxp xxpxxxxp commented Feb 8, 2021

I'm writing a plugin for Goland to support golangci-lint inline, also providing possible quick fixes: https://github.com/xxpxxxxp/intellij-plugin-golangci-lint
Should be stable now, I'd like to suggest it as an option for Goland users.
Thank you all authors, golangci-lint is widely used in my org and improved code quality significantly.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 8, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2021

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented Feb 8, 2021

Hello,

what is the interest of your plugin compared to native integration (FileWatcher)?

@ldez ldez added area: docs feedback required Requires additional feedback labels Feb 8, 2021
@xxpxxxxp
Copy link
Contributor Author

xxpxxxxp commented Feb 8, 2021

Well, FileWatcher is tough to work with, one has to save the current file then find issues in the output panel, go back to fix them.
This plugin is hinting issues inline, providing quick fix to some issues, see example below

image

@ldez ldez removed the feedback required Requires additional feedback label Feb 8, 2021
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this plugin with IntelliJ and I think it's a nice addition instead of using file watchers. Sounds reasonable to reference this in the docs.

@ldez ldez merged commit 3ef13a8 into golangci:master Feb 8, 2021
@ldez ldez added the enhancement New feature or improvement label Feb 8, 2021
@golangci-automator
Copy link

Hey, @xxpxxxxp — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants