Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in "unused" linter since upgrade to go-tools 0.4.0 #3569

Closed
4 tasks done
vitaly-eureka-security opened this issue Feb 6, 2023 · 4 comments
Closed
4 tasks done
Labels
bug Something isn't working feedback required Requires additional feedback

Comments

@vitaly-eureka-security
Copy link

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc.).
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

The release of go-tools Staticcheck 2023.1 (v.0.4.0) introduced regression: dominikh/go-tools#1360.
This regression propagated to golangci-lint 1.51.1.
According to dominikh/go-tools#1360 (comment) the fix for go-tools should be released on Feb 6th.

Version of golangci-lint

golangci-lint has version 1.51.1 built from b87d2c1 on 2023-02-05T13:06:33Z

Configuration file

Go environment

Verbose output of running

Code example or link to a public repository

@vitaly-eureka-security vitaly-eureka-security added the bug Something isn't working label Feb 6, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 6, 2023

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez
Copy link
Member

ldez commented Feb 6, 2023

Hello,

Can you fill in the template and add a reproducible example?

@ldez ldez added the feedback required Requires additional feedback label Feb 6, 2023
@ldez
Copy link
Member

ldez commented Feb 6, 2023

when staticcheck will create a release we will update.

dominikh/go-tools#1360 (comment)

@ldez
Copy link
Member

ldez commented Feb 14, 2023

Fixed by #3591

@ldez ldez closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback required Requires additional feedback
Projects
None yet
Development

No branches or pull requests

2 participants