Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: check default lists configuration reference #4134

Closed
Antonboom opened this issue Oct 17, 2023 · 1 comment · Fixed by #4146
Closed

doc: check default lists configuration reference #4134

Antonboom opened this issue Oct 17, 2023 · 1 comment · Fixed by #4146

Comments

@Antonboom
Copy link
Contributor

Your feature request related to a problem? Please describe.

$ grep ': \[\]' .golangci.reference.yml
  # Default: [].
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
      # Default: []
      # Default: []
      # Default: []
      # Default: []
    # Default: [] - means include all rules
    # Default: []
    # Default: []
        # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
    # Default: []
  # Default: []
  # Default: []

Describe the solution you'd like.

  1. Review configuration.
  2. If default is really empty – no changes.
  3. If default is not empty – add value and context in the comment.
  4. Change rule about this field in the new-linter-checklist

Describe alternatives you've considered.

Let it be as it is.

Additional context.

#4127 (comment)

@Antonboom Antonboom added enhancement New feature or improvement area: config Related to .golangci.yml and/or cli options labels Oct 17, 2023
@ldez
Copy link
Member

ldez commented Oct 17, 2023

The majority of those empty defaults are real.

@ldez ldez changed the title Configuration reference: make default lists make sense doc: check default lists configuration reference Oct 17, 2023
@ldez ldez added area: docs and removed enhancement New feature or improvement area: config Related to .golangci.yml and/or cli options labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants