Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add contributor to list? #106

Closed
goldbergyoni opened this issue Jan 9, 2020 · 10 comments
Closed

How to add contributor to list? #106

goldbergyoni opened this issue Jan 9, 2020 · 10 comments

Comments

@goldbergyoni
Copy link
Owner

@js-kyle Layman question - when I approve John Doe's PR, will he be added automatically to the list or should I do anything manual?

@js-kyle
Copy link
Collaborator

js-kyle commented Jan 10, 2020

It isn't fully automated - when you want to add a contributor, you request the bot to add them by mentioning it in an issue comment, by using the command

@all-contributors-bot please add @goldbergyoni for content

https://github.com/goldbergyoni/nodebestpractices/blob/master/.operations/CONTRIBUTING.md#other-contributions-

@js-kyle
Copy link
Collaborator

js-kyle commented Jan 10, 2020

It seems the bot isn't working as it should today :(

I will try it again soon - there might be an outage to the service

@js-kyle
Copy link
Collaborator

js-kyle commented Jan 13, 2020

@all-contributors-bot please add @goldbergyoni for content

@goldbergyoni
Copy link
Owner Author

OK, let me try

@all-contributors-bot please add @js-kyle for content

@goldbergyoni
Copy link
Owner Author

That's easy, even I can do this. Ping once it's up again and I'll add the latest contributos

@js-kyle
Copy link
Collaborator

js-kyle commented Jan 21, 2020

Does the bot still have access to the repository? It is a bit strange it isn't working anymore

@js-kyle
Copy link
Collaborator

js-kyle commented Jan 21, 2020

@all-contributors-bot please add @goldbergyoni for content

@js-kyle
Copy link
Collaborator

js-kyle commented Feb 3, 2020

@all-contributors please add @goldbergyoni for content

@allcontributors
Copy link
Contributor

@js-kyle

I've put up a pull request to add @goldbergyoni! 🎉

@js-kyle
Copy link
Collaborator

js-kyle commented Feb 3, 2020

Okay @goldbergyoni I just had the command wrong the whole time 😅

I can see you've worked this out out - it works the same way as on the nodebestpractices repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants