Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is using hard-coded API URL, make it dynamic #19

Open
goldbergyoni opened this issue Feb 10, 2019 · 0 comments
Open

UI is using hard-coded API URL, make it dynamic #19

goldbergyoni opened this issue Feb 10, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers mandatory-for-release

Comments

@goldbergyoni
Copy link
Owner

Why: The UI is approaching hard-coded 'localhost:8080' API address, but in reality the UI+API might be loaded from other ports and URLs

How: Approach an API that is always on the same URL as the UI, I believe that using '/' is sufficient. Note: the web socket port is always 9090

@goldbergyoni goldbergyoni added enhancement New feature or request good first issue Good for newcomers mandatory-for-release labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers mandatory-for-release
Projects
None yet
Development

No branches or pull requests

1 participant