Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximizing in the official "Adding items to a predefined layout" CodePen doesn't work #847

Open
AlexErrant opened this issue Jul 8, 2023 · 2 comments

Comments

@AlexErrant
Copy link

Current behavior

  1. Go to the CodePen: https://codepen.io/pbklink/pen/dyWJNNm Note that this is the codepen linked in the v2 docs.
  2. Hover over the right corner of any window until you get a tooltip for the Maximize button. (The Maximize button blends into the background - the CSS is not great, but not the point of this issue.)
  3. Click
  4. Scroll down. Observe that the other panel is visible... which is weird.

Expected behavior:
If one panel is maximized, the other window should not be visible. Also, no scrolling should be possible

Codepen example:
https://codepen.io/pbklink/pen/dyWJNNm

@ratatoeskr666
Copy link

Yes... I can confirm. Maximizing seems to be broken (V2.6.0)
The 'maximised' event is also not being triggered:

 container.addEventListener('maximised', () => this.onContainerMaximizes(container)); // Not being called :( 

@ratatoeskr666
Copy link

I found out the workaround (maybe the issue is correlated to the broken CSS):

.lm_root {
    overflow: hidden;
}

The maximized container is being prepended under the ground item (root) by design. Everything else is moved outside the frame (and the original stack is being replaced by a placeholder).
The implementation requires the root to be overflow: hidden so that the rest is no longer visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants