Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it work fine with Electron.atom? #91

Closed
VinciShark opened this issue Apr 13, 2016 · 10 comments
Closed

Is it work fine with Electron.atom? #91

VinciShark opened this issue Apr 13, 2016 · 10 comments
Labels
Question Something better suited to StackOverflow, but might get answered here Wontfix Issues we won't fix/can't fix

Comments

@VinciShark
Copy link

Is it work fine with Electron.atom? That may help to build desktop cross-platform applications.

@WolframHempel
Copy link
Collaborator

Good question, I haven't tried it yet, but it would certainly make sense

@barbalex
Copy link

Works nice for me. Thanks for this amazing tool

@VinciShark
Copy link
Author

@barbalex @WolframHempel the popupwindow in electron can't go back to main window, and the data is not right

@redreamality
Copy link

redreamality commented Apr 24, 2016

@barbalex I just applied this, however I didn't see that EventHub is supporting Electron's IPC. In detail, I tried applied the react demo to electron app, which didn't send information between windows.

@WolframHempel
Copy link
Collaborator

In order to work in every browser, GoldenLayout's inter-window message bus traverses window.opener objects and raises DOM events within them (code here). Electron has its own inter-window communication mechanism, I'd recommend just using that one instead.

@barbalex
Copy link

I do not use popup windows, only the layouting

@TheLevenCreations
Copy link

+1, the popup windows doesn't work, according to the doc http://electron.atom.io/docs/v0.37.7/api/window-open/ , the window.open will return a BrowserWindowProxy object.

@Jmales
Copy link

Jmales commented Feb 3, 2017

Did any of you guys found a way of poping the panels out and in?

@emretoprak
Copy link

Most important key is nativeWindowOpen

This is my options everything is good but except "pop in" action.

new BrowserWindow({
show: false,
title: app.getName(),
x: windowState.x,
y: windowState.y,
width: windowState.width,
height: windowState.height,
alwaysOnTop: config.get('alwaysOnTop'),
autoHideMenuBar: config.get('autoHideMenuBar'),
backgroundColor: '#f2f2f2',
icon: path.join(__dirname, '..', 'static/Icon.png'),
frame: true,
webPreferences: {
preload: path.join(__dirname, '..', 'renderer', 'browser.js'),
nativeWindowOpen: true,
nodeIntegration: false,
},
});

@martin31821 martin31821 added Question Something better suited to StackOverflow, but might get answered here Wontfix Issues we won't fix/can't fix labels Jan 23, 2020
@martin31821
Copy link
Member

As emretoprak said, when setting nativeWindowOpen, it does indeed work fine in electron.
I'm using v1.5.9 in an electron 7 app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Something better suited to StackOverflow, but might get answered here Wontfix Issues we won't fix/can't fix
Projects
None yet
Development

No branches or pull requests

8 participants