Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wish List: A little Bookmark Button in the toolbar #835

Closed
skywind3000 opened this issue Apr 20, 2017 · 22 comments
Closed

Wish List: A little Bookmark Button in the toolbar #835

skywind3000 opened this issue Apr 20, 2017 · 22 comments

Comments

@skywind3000
Copy link

skywind3000 commented Apr 20, 2017

Having been using GD for almost 3 years, I really love it. I know a lot of translators profit from GD every day.
Thanks for your work.

I lookup nearly 100 words every day in GD. All I want is to mark some of them as "important words" which can be reviewed or studied later. These important words can also be imported to Anki to get memorized.

A bookmark button is required because a lot of words in the history list is not so important.

Therefor, can we have this bookmark list in GD ? Just like the history list (add/delete/import/export).
In the toolbar, a STAR icon beside the magnifier button can be used to add current word into the bookmark list or remove it from list if it has been previously added.

We can press CTRL-D to bookmark a word or un-bookmark it.
We can browse marked words in the bookmark list window which is hidden by default but could show itself in the "View" menu option, and also it could attach to the window border just like the history window.

Studying / Working will be more productive if we have this "bookmark feature" in GD.

GD is similar to a web browser. A good web browser has bookmark list, a good desktop dictionary should have a bookmark list too.

@skywind3000 skywind3000 changed the title Feature Request: Bookmark List Feature Request: A little Bookmark Button in the toolbar Apr 20, 2017
@skywind3000 skywind3000 changed the title Feature Request: A little Bookmark Button in the toolbar Wish-List: A little Bookmark Button in the toolbar Apr 20, 2017
@skywind3000 skywind3000 changed the title Wish-List: A little Bookmark Button in the toolbar Wish List: A little Bookmark Button in the toolbar Apr 20, 2017
@itkind
Copy link

itkind commented May 8, 2017

I would love to have this funktion. PLEASE! I will donate 50€

@skywind3000
Copy link
Author

To some one who can implement this feature, I will also pay him 500€ for appreciation.

@itkind
Copy link

itkind commented May 9, 2017

I saw in the Russian forum, that Abs is already working on this since last week. I think we will have it soon.

@skywind3000
Copy link
Author

skywind3000 commented May 9, 2017

@itkind Do you still remember the URL about this topic in the Russian forum ?

@itkind
Copy link

itkind commented May 9, 2017

Sure, but you have to register first:
http://forum.ru-board.com/topic.cgi?forum=5&topic=49149&start=320

@skywind3000
Copy link
Author

thanks, do you know what does Abs's latest reply mean about the 1.5.0 final release:

Релиз делать некому, вот и весь критерий.

Google translation interpreted it as: "Release there is nobody to do, that's the whole criterion."

Do you know what does it mean ?

@darnn
Copy link

darnn commented May 9, 2017

Pretty much what Google Translate says: "There's nobody to make the release, there's your whole criterion."

@itkind
Copy link

itkind commented May 9, 2017

@skywind3000
If you are already registered, check out the huge dictionary archive:
http://forum.ru-board.com/topic.cgi?forum=93&topic=2618#1

You can also find my dictionaries there.

@skywind3000
Copy link
Author

What a great treasure it is.
I also found your dictionaries about judaica, thanks a lot.

@Abs62
Copy link
Member

Abs62 commented May 13, 2017

Try - goldendict-1.5.0-RC2-105-g61295ce(EXE only).7z (EXE for early access builds 1.5.0-RC-85).

@skywind3000
Copy link
Author

skywind3000 commented May 13, 2017

Thanks very much, some feedback:

It crashed when I was trying to delete two or more items together (folders or words).

gd1

reproduce:

  1. select two or more items at one time in the favorites.
  2. delete them

And why there is an empty column before the words in the favorite pane, what is it used for ?

At last, can I have a hot key to add current word into favorite list ?

@Eosphorus
Copy link

First off, great work, Abs62!

'Favorites' is a really useful new feature to an already great program. And funny thing is: I didn't know that I missed it until just now.

Ok, it needs some refinement though. I can confirm those crashes, see below. But it doesn't give out every time I delete some words; it seems rather erratic.

Where is that bug?!

screenshot - 13 05 2017 18_25_15

@Abs62
Copy link
Member

Abs62 commented May 13, 2017

It crashed when I was trying to delete two or more items together (folders or words).

Fixed - goldendict-1.5.0-RC2-107-g2bf4c51(EXE only).7z.

And why there is an empty column before the words in the favorite pane, what is it used for ?

For tree structure as in any TreeView.

At last, can I have a hot key to add current word into favorite list ?

Will be "Ctrl+E".

@itkind
Copy link

itkind commented May 14, 2017

@Abs62
Give me your PayPal address, so I can send you the promised 50€.

@skywind3000
Copy link
Author

skywind3000 commented May 14, 2017

@Abs62
Thank you for this great feature, I am ready to make the payment too.

@skywind3000
Copy link
Author

Having invited almost 10 people to test and got some feedback:

  1. Never crash while deleting items.

  2. The preview window (you know, the Ctrl-C-C Window) also needs a favorite button and CTRL-E hotkey:

favorite

When they were reading fictions they preferred to use preview window rather than the main GD window.
And most of them wanted a "star button" (also CTRL-E) in the preview window.

@Abs62
Copy link
Member

Abs62 commented May 15, 2017

@Abs62
Copy link
Member

Abs62 commented May 15, 2017

New help files you can take from GD sources.

@Eosphorus
Copy link

Eosphorus commented May 17, 2017

Since I usually (well... sometimes) know what I am doing, how can I suppress the inquiry when deleting an item on the list?
"All selected items will be deleted. Continue?"

For now, I commented these code lines in file "favoritespanewidget.cc" out:

/*
QMessageBox mb( QMessageBox::Warning, "GoldenDict",
tr( "All selected items will be deleted. Continue?" ),
QMessageBox::Yes | QMessageBox::No );
mb.exec();
if( mb.result() != QMessageBox::Yes )
return;
*/

But for convenience's sake, an option in 'Preferences' would be nice here.

@Abs62
Copy link
Member

Abs62 commented May 17, 2017

@skywind3000
Copy link
Author

skywind3000 commented Jun 6, 2017

After 20 days, I believe the favorite pane is stable enough.
Only this picture can express our gratitude:

panda

Expecting next release on https://github.com/goldendict/goldendict/wiki/Early-Access-Builds-for-Windows

Has it been planned ?

@Abs62
Copy link
Member

Abs62 commented Jun 6, 2017

Planned. At the right time or some later.

@Abs62 Abs62 closed this as completed Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants