Add support for withCredentials #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the use-case for this? |
|
For when we have a cross site request where we need to send cookie information. In my particular case I am requesting a file from another domain and I need to send cookie credentials otherwise the other domain will reject my request. https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials |
|
Are there any issues keeping this from being merged? |
ringcrl
pushed a commit
to ringcrl/howler.js
that referenced
this pull request
Apr 21, 2019
Add support for withCredentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for withCredentials flag on the xhr object.