Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when seeking with unloaded state #797

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Stenerson
Copy link
Contributor

This is a fix for #796

We could also check the length of ids but I think the intention is more clear by using self._sounds.

If the state is unloaded there will be no _sounds so the id will be left as undefined and the function will bail on line 1370:

1368:      // If there is no ID, bail out.
1369:      if (typeof id === 'undefined') {
1370:        return self;
1371:      }

@goldfire
Copy link
Owner

Thanks!

@goldfire goldfire merged commit 888f8ac into goldfire:master Aug 18, 2017
ringcrl pushed a commit to ringcrl/howler.js that referenced this pull request Apr 21, 2019
Fix error when seeking with unloaded state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants