Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any need to have this? #30

Closed
gilbertoalbino opened this issue Jul 17, 2020 · 1 comment
Closed

Is there any need to have this? #30

gilbertoalbino opened this issue Jul 17, 2020 · 1 comment
Labels
question Further information is requested

Comments

@gilbertoalbino
Copy link

@gilbertoalbino gilbertoalbino changed the title Is there need to have this? Is there any need to have this? Jul 17, 2020
@matthew-inamdar
Copy link
Member

@gilbertoalbino you're right in thinking there's no need.

Its existence is due to this package starting out as something for us to use for our own projects, so it's the remains of a timesaver.

I don't feel comfortable removing this now as existing projects could break which would warrant a major release, and that gets weird as the versioning system used mirrors the major version of the currently supported Laravel version.

If you're facing issues in your own project, you can override the property in the classes needed.

@matthew-inamdar matthew-inamdar added the question Further information is requested label Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants