Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Revise Task interface #66

Closed
azawlocki opened this issue Dec 1, 2015 · 3 comments
Closed

Revise Task interface #66

azawlocki opened this issue Dec 1, 2015 · 3 comments

Comments

@azawlocki
Copy link
Contributor

  • We have both computation_finished() and finished_computation() methods
  • query_extra_data() should probably be changed to a better name
  • Is there a difference between needs_computation() and get_tasks_left() != 0?
@badb
Copy link
Contributor

badb commented Dec 2, 2015

Remember to check wiki

  1. finished_computatation is a question, computation_finished information. Do you have better ideas for names?
  2. Maybe get_next_subtask?
  3. In current tasks there is no difference. We can imagine some scenarios where it may be a difference, but in most cases it should mean the same.

@chfast chfast added the planned label Dec 2, 2015
@azawlocki
Copy link
Contributor Author

  1. maybe on_computation_finished, since this is kind of a callback? Or react_to_computation_finished. Some general convention would be useful here.
  2. sounds good
  3. I see

@badb
Copy link
Contributor

badb commented Dec 3, 2015

  1. Personally I prefer react_to_computation_finished (convention with verb), but other proposition is also good.

@chfast chfast added the design label Apr 6, 2016
@badb badb added this to the Clay milestone May 22, 2016
@badb badb removed the planned label Jul 12, 2016
@badb badb removed the design label Aug 24, 2017
@badb badb removed this from the Clay milestone Sep 28, 2017
@badb badb removed the planned label Mar 15, 2018
@badb badb closed this as completed May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants