Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments never get SETTLED when spawning multiple activities #116

Closed
nieznanysprawiciel opened this issue Apr 11, 2024 · 1 comment · Fixed by #114
Closed

Payments never get SETTLED when spawning multiple activities #116

nieznanysprawiciel opened this issue Apr 11, 2024 · 1 comment · Fixed by #114
Assignees
Labels
bug Something isn't working

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented Apr 11, 2024

Use reproduction scenario from task: #113

Image

Although we have 2 payment confirmations, payments status is not set 2 SETTLED. Since second confirmation is agreement payment I assumed that it should be the last payment.

It still possible that I didn't wait enough time. Requires investigation.

Investigation:
Bugs seems strictly related to scenario, when we have multiple Activities. It seems that payments module doesn't work correctly in this case and never sets status to SETTLED. Problem is caused by this part of code:
https://github.com/golemfactory/yagna/blob/60d103cfcd9194a38afd285dc20f0651a3d9e22d/core/payment/src/dao/agreement.rs#L128-L131
We don't check activity payments here, so later this if https://github.com/golemfactory/yagna/blob/60d103cfcd9194a38afd285dc20f0651a3d9e22d/core/payment/src/dao/agreement.rs#L149-L157
isn't triggered.

The same happens for mid-agreement payments without multiple activities

@nieznanysprawiciel nieznanysprawiciel added the bug Something isn't working label Apr 11, 2024
@nieznanysprawiciel nieznanysprawiciel changed the title Payments never get SETTLED Payments never get SETTLED when spawning multiple activities Apr 12, 2024
@nieznanysprawiciel
Copy link
Contributor Author

Other bug related to multi-activity scenario: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant