Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple services via a single binary #5

Closed
mfranciszkiewicz opened this issue Jan 10, 2022 · 1 comment · Fixed by #10
Closed

Support multiple services via a single binary #5

mfranciszkiewicz opened this issue Jan 10, 2022 · 1 comment · Fixed by #10
Assignees
@wkargul
Projects
.Core

Comments

@mfranciszkiewicz
Copy link
Contributor

mfranciszkiewicz commented Jan 10, 2022 •
edited
Loading

What:

  • Refactor the existing code according to GAP-8 in order to support multiple services via a single binary (via Dynamic runtime name ya-runtime-sdk#19)
    • update the command line interface
    • update runtime configuration
    • implement service configuration file lookup
    • implement binary startup file lock mechanism
    • update the deploy and start commands

Why:

  • previous runtime implementation supported only a single service per binary / runtime configuration
@mfranciszkiewicz mfranciszkiewicz mentioned this issue Jan 10, 2022
Closed
4 tasks
@mfranciszkiewicz mfranciszkiewicz added this to Inbox in .Core via automation Jan 10, 2022
@nieznanysprawiciel nieznanysprawiciel moved this from Inbox to To do in .Core Jan 11, 2022
@wkargul wkargul moved this from To do to In progress in .Core Jan 18, 2022
@wkargul
Copy link
Contributor

wkargul commented Jan 24, 2022 •
edited
Loading

@mfranciszkiewicz those subtasks are done (feature branch) and ready for your review:

  • implement service configuration file lookup
  • update the deploy and start commands

What do you think about splitting the issue if there are any blocking items for those subtasks completion?

Still pending:

  • update the command line interface
  • update runtime configuration
  • implement binary startup file lock mechanism

@wkargul wkargul mentioned this issue Jan 24, 2022
Merged
@wkargul wkargul linked a pull request Jan 24, 2022 that will close this issue
Service config file lookup and minor updates #10
Merged
.Core automation moved this from In progress to Done Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkargul wkargul

Labels
None yet
Projects
.Core
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Service config file lookup and minor updates golemfactory/ya-runtime-http-auth
2 participants
@mfranciszkiewicz @wkargul