Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agreements pool #188

Merged
merged 9 commits into from Dec 18, 2020
Merged

Agreements pool #188

merged 9 commits into from Dec 18, 2020

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Dec 14, 2020 •
edited by tworec

azawlocki
azawlocki suggested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested some changes but I like the overall approach very much. I'll try to run some tests later on.

yapapi/executor/agreements_pool.py Outdated Show resolved Hide resolved
yapapi/executor/agreements_pool.py Outdated Show resolved Hide resolved
yapapi/executor/agreements_pool.py Outdated Show resolved Hide resolved
yapapi/executor/agreements_pool.py Show resolved Hide resolved
yapapi/executor/agreements_pool.py Outdated Show resolved Hide resolved
yapapi/executor/agreements_pool.py Outdated Show resolved Hide resolved
yapapi/executor/__init__.py Outdated Show resolved Hide resolved
yapapi/executor/__init__.py Outdated Show resolved Hide resolved
@tworec tworec added this to In progress in Mkt & Prov (Yagna Core) via automation Dec 16, 2020
@tworec tworec moved this from In progress to Review in progress in Mkt & Prov (Yagna Core) Dec 16, 2020
azawlocki
azawlocki suggested changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. There's just one unresolved item left, the one about emitting the ProposalFailed event.

azawlocki
azawlocki suggested changes Dec 18, 2020
View reviewed changes
yapapi/executor/__init__.py Outdated Show resolved Hide resolved
@jiivan @azawlocki
Update yapapi/executor/__init__.py
b08e005 
Co-authored-by: azawlocki <artur.zawlocki@golem.network>
azawlocki
azawlocki approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiivan jiivan merged commit e89476e into master Dec 18, 2020
Mkt & Prov (Yagna Core) automation moved this from Review in progress to Done Dec 18, 2020
@jiivan jiivan deleted the agreement_pool branch December 18, 2020 12:40
@tworec tworec moved this from Done to Archive in Mkt & Prov (Yagna Core) Jan 13, 2021
@tworec tworec moved this from Archive to Done in Mkt & Prov (Yagna Core) Jan 13, 2021
@azawlocki azawlocki mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

Assignees

@jiivan jiivan

Labels
None yet
Projects
No open projects
Mkt & Prov (Yagna Core)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiivan @azawlocki