Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JQuery #1916

Open
bartkamphorst opened this issue Dec 22, 2022 · 5 comments
Open

Update JQuery #1916

bartkamphorst opened this issue Dec 22, 2022 · 5 comments

Comments

@bartkamphorst
Copy link
Member

Gollum currently still uses JQuery 1.7.2. We should see if we can update the library, since the latest release is already on 3.6.3. This might require some serious work though, depending on the breaking changes from those major releases.

@benjaminwil
Copy link
Member

I tried doing this when initially moving over to Yarn for dependency management.

There is at least one feature that just no longer exists in modern JQuery. But I don't remember which one it is, sorry; it was immediately evident the moment I upgraded from the console errors, though.

So, yes, a little bit of serious work.

@dometto
Copy link
Member

dometto commented Dec 27, 2022

This might be of use: https://github.com/jquery/jquery-migrate

@bartkamphorst
Copy link
Member Author

There is at least one feature that just no longer exists in modern JQuery.

Was it $.browser by any chance? I'm trying to upgrade jQuery from 1.7.2 to 1.9.1 and so far this is the only issue I've come across for this version.

@benjaminwil
Copy link
Member

That may have been it… I really have no memory of this anymore! LOL.

@bartkamphorst
Copy link
Member Author

jQuery has been updated to 1.9.1 in #1991 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants