Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard button styling is unresponsive #1942

Open
Tracked by #1365
dometto opened this issue Jan 16, 2023 · 5 comments
Open
Tracked by #1365

Copy to clipboard button styling is unresponsive #1942

dometto opened this issue Jan 16, 2023 · 5 comments
Assignees

Comments

@dometto
Copy link
Member

dometto commented Jan 16, 2023

I noticed that if you zoom out a lot in your browser, the copy to clipboard button doesn't really scale/position well. This is a rather niche issue so I'm happy to close this as a wontfix, unless it's necessary to fix this for a good mobile experience. But I'm assuming the button won't even show up on mobile?

Screenshot 2023-01-16 at 20 14 16

@dometto
Copy link
Member Author

dometto commented Jan 16, 2023

Note: this must be a consequence of using position-absolute for the button positioning.

@benjaminwil
Copy link
Member

I'm currently dealing with other issues related to this button, so I might as well think about this issue while I'm in there.

Other issues include:

  • Making this button keyboard accessible.
  • Making this button aware of browser clipboard API permissions.

@benjaminwil benjaminwil self-assigned this Jan 16, 2023
@dometto
Copy link
Member Author

dometto commented Jan 16, 2023

Amazing, thanks!

@bartkamphorst
Copy link
Member

@benjaminwil This issue was resolved, yes?

@benjaminwil
Copy link
Member

I will have to double-check, as I can't really remember exactly how complete my work related to this button ended up being. I will close once I've verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants